Ticket #6 (closed defect: fixed)

Opened 8 years ago

Last modified 8 years ago

win32 function name mismatch in clisp and lispworks

Reported by: afuchs Owned by: default
Priority: major Milestone: release-0.2
Component: tcp-socket Version: 0.1.0
Keywords: Cc:
Patch included: yes

Description

some backend/*.lisp files define a remap-maybe-for-win32 function, but use a remap-for-win32 function. That prevents loading of usocket at least in lispworks/win32, but I believe it will cause trouble for clisp as well.

Here's a patch that I believe fixes this:

Index: clisp.lisp
===================================================================
--- clisp.lisp	(revision 117)
+++ clisp.lisp	(working copy)
@@ -17,8 +17,8 @@
 
 (defparameter +clisp-error-map+
   #+win32
-  (append (remap-for-win32 +unix-errno-condition-map+)
-          (remap-for-win32 +unix-errno-error-map+))
+  (append (remap-maybe-for-win32 +unix-errno-condition-map+)
+          (remap-maybe-for-win32 +unix-errno-error-map+))
   #-win32
   (append +unix-errno-condition-map+
           +unix-errno-error-map+))
Index: lispworks.lisp
===================================================================
--- lispworks.lisp	(revision 117)
+++ lispworks.lisp	(working copy)
@@ -19,8 +19,8 @@
 
 (defparameter +lispworks-error-map+
   #+win32
-  (append (remap-for-win32 +unix-errno-condition-map+)
-          (remap-for-win32 +unix-errno-error-map+))
+  (append (remap-maybe-for-win32 +unix-errno-condition-map+)
+          (remap-maybe-for-win32 +unix-errno-error-map+))
   #-win32
   (append +unix-errno-condition-map+
           +unix-errno-error-map+))

Change History

Changed 8 years ago by afuchs

  • patch set

Changed 8 years ago by ehuelsmann

  • status changed from new to closed
  • resolution set to fixed

Accepted and resolved this issue: patch applied in r118.

Note: See TracTickets for help on using tickets.