Opened 19 years ago

Closed 19 years ago

#6 closed enhancement (fixed)

[patch] keep server port and password in connection object

Reported by: afuchs Owned by: Erik Huelsmann
Priority: major Milestone:
Component: chat Version:
Keywords: Cc:
Patch attached: yes

Description

Beirc needs the port and password used to establish a connection in order to reliably reconnect to the same server (ssh port forwards for example can cause localhost to have many irc ports open). So, the attached patch adds them as slots to the connection object.

The patch requires the "external format guessing" patch in order to apply correctly, but the code will run independently. If needed, I'll create another patch that applies to vanilla cl-irc.

Attachments (1)

,port-and-password-in-connection-object.patch (4.0 KB) - added by afuchs 19 years ago.

Download all attachments as: .zip

Change History (5)

comment:1 Changed 19 years ago by afuchs

Type: defectenhancement

comment:2 Changed 19 years ago by Erik Huelsmann

Owner: changed from somebody to Erik Huelsmann

Change sounds reasonable, accepting the issue, but since the patch

depends on the encoding-guessing patch (in issue #2), holding up until that one is committed.

comment:3 Changed 19 years ago by Erik Huelsmann

Status: newassigned

comment:4 Changed 19 years ago by Erik Huelsmann

Resolution: fixed
Status: assignedclosed

This issue has been fixed in r157.

I reserve the right to change all this later though: I think a connection object should hold either or both some userdata and configuration data. (Ticket #16)

At least closing the patch ticket.

The commit is a close resemblense, but not a 1-1 application of the patch attached to the issue.

Note: See TracTickets for help on using tickets.