close Warning: Can't synchronize with repository "(default)" (/project/cl-openid/svn does not appear to be a Subversion repository.). Look in the Trac log for more information.

Opened 14 years ago

Closed 14 years ago

Last modified 14 years ago

#17 closed defect (fixed)

signal an error if discovery discovers nothing

Reported by: avodonosov Owned by:
Priority: major Milestone:
Component: code Version: 1.0 portable
Keywords: Cc:

Description

If discovery process doesn't discover the necessary information (provider endpoint at least, but we should check by the spec the minimum required attribute list), the function should signal an error, instead of leaving NILs in the AUTHPROC structure, and allow the library fail later (which is inconvenient to debug).

It's necessary to add a check to the end of the discovery process, that verifies that the required minimum of information is discovered.

I encountered this problem when was recently testing with technorati.com - they previously were providing OpenID, and I registered an account.

The OpenID identity URL is ​http://technorati.com/people/technorati/clopenid. Today this page does not have the <link> tags necessary for discovery. In result, the discovery process just silently created an AUTHPROC struct with NILs. The error occurred somewhere later in the control flow.

Change History (4)

comment:1 Changed 14 years ago by avodonosov

Version: 0.5 nonportable → 1.0 portable

comment:2 Changed 14 years ago by avodonosov

Summary: signal an error if discovery didn't discovered anything → signal an error if discovery discovers nothing

comment:3 Changed 14 years ago by avodonosov

Resolution: → fixed
Status: new → closed

Fixed. Not using this URL as an OpenID identifier correctly signals an error.

comment:4 in reply to:  3 Changed 14 years ago by avodonosov

Replying to avodonosov:

Fixed. Not using this URL as an OpenID identifier correctly signals an error.

*Now* using this URL....

Note: See TracTickets for help on using tickets.