close Warning: Can't synchronize with repository "(default)" (/project/cmucl/public_html/git/cmucl.git does not appear to be a Git repository.). Look in the Trac log for more information.

Opened 4 years ago

Last modified 3 years ago

#91 new defect

ppc fails tan.exceptions test

Reported by: rtoy Owned by: somebody
Priority: major Milestone:
Component: Core Version: 2014-01
Keywords: Cc:

Description

The test (tan ext:double-float-positive-infinity) correctly generates an invalid operation, but the test code doesn't catch it for some reason.

Change History (2)

comment:1 Changed 3 years ago by toy.raymond@…

commit 70181ee7553a350eedd7acb2815b98dde6ce846c Author: Raymond Toy <toy.raymond@…> Date: Sat Nov 29 21:00:38 2014 -0800

Partially addresses ticket:91 by allowing the test suite to finish. The tests still fail (along with others), but the test suite will finish.

  • code/float-trap.lisp:
    • Update SET-FLOATING-POINT-MODES:
      • When we clear out bits in float-invalid-op-1-byte, clear out the float-invalid-op-2-byte. Not necessary for this fix, but those bits signal other invalid operations from sqrt and such.
      • When clearing the exceptions, clear the sticky exceptions summary bit too.
    • Fix SIGFPE-HANDLER:
      • As above, clear out the bit in float-invalid-op-2-byte and the exceptions summary bit.
      • Only clear out the new exception bits, as done for SSE2.
      • Mask out the float-invalid-op-2-byte and the summary bit before setting the new modes.

  • compiler/ppc/parms.lisp
    • Define float-exceptions-summary-byte.

  • code/exports.lisp:
    • Export FLOAT-INVALID-OP-2-BYTE

comment:2 Changed 3 years ago by toy.raymond@…

commit 46b8066952521e9d7c43ff101677725425c851a8 Author: Raymond Toy <toy.raymond@…> Date: Sat Nov 29 21:43:09 2014 -0800

See ticket:91: Forgot to export FLOAT-EXCEPTIONS-SUMMARY-BYTE.

Note: See TracTickets for help on using tickets.